fix: localize Extra info chrome and Assets inspector - #77
Merged
Conversation
Wire leftover Extra info labels to activity.extraInfo and move the Assets Extra info inspector internals into activity.inspector keys.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d60c2bd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Follow-up acotado de Extra info. No traduce el resto de la app ni el cuerpo de
VideoExtraInfoDialog.VideoExtraInfoDialogtítulo,MediaFeedItem,VideoInfoBar) usaactivity.extraInfoAssetExtraInfoDialog+ error de carga) pasa a clavesactivity.inspector.*common.actions.closeZona migrada
Chrome Extra info + interiores del inspector de Assets.
Deuda que permanece
Etiquetas de campos de
VideoExtraInfoDialog, listado de Assets, resto de paneles. No se toca init i18n niescapeValue.Verificación local
npm run i18n:checknpm test(485)--max-warnings=0npx tsc -b --pretty falsePendiente de CI en GitHub.
No se han tocado launchers, WanGP, modelos ni
comunicaciones/.Note
Low Risk
Presentation-only i18n wiring and catalog keys; no API, auth, or data-path changes.
Overview
Continues the UI i18n pilot by routing Extra info labels through
activity.extraInfoinMediaFeedItem,VideoInfoBar, and theVideoExtraInfoDialogtitle (dialog body copy is unchanged).The Assets extra-info inspector drops hardcoded Spanish/English strings in favor of new
activity.inspector.*keys (loading, sections, copy actions, JSON, errors) andcommon.actions.closefor the dismiss control;AssetExtraInfoDialogis reformatted for readability.check-i18n-catalogsexpands pilot file coverage for the video components and forbids the literal"Extra info". Tests assert catalog usage and parity of the new keys in EN/ES.Reviewed by Cursor Bugbot for commit d60c2bd. Configure here.